Config: add a new no-op discovery type #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thrawn01 , whenever you have time, could you help review this PR? Thanks. |
|
This is great! Thanks for making this change. Instead of "embedded" can we call it "none" as we don't want to configure any discovery, since it will be set by your code. |
Thanks for your quick review. I like the name |
huikang
force-pushed
the
huikang/embedded-discovery-type
branch
from
f6837cc to
e882146
Compare
thrawn01
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are using an in-house service discovery mechanism, we need to set the
GUBER_DISCOVERY_TYPEto something other than the existing list.This PR adds a new discovery type named
embeddedsuch thatit allows us to embed gubernator and manually call the methoddaemon.SetPeersto set the gubernator peers. I understood that we can bypass the configuration check by manually creatingDaemonConfig. However, using theSetupDaemonConfigis much easier and has proven to work for most settings.Therefore, with this PR, users can easily embed gubernator and manually set the peers.