Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More safety updates, fix for Terminal Services on Windows 10, update to Detours and Readme Update #86

Merged
merged 6 commits into from
Jan 23, 2025
Merged

More safety updates, fix for Terminal Services on Windows 10, update to Detours and Readme Update #86

merged 6 commits into from
Jan 23, 2025

Conversation

Voidless7125
Copy link
Collaborator

@Voidless7125 Voidless7125 commented Jan 19, 2025 •
edited
Loading

GetSystemMetrics-Hook.cpp and sandbox_run.ps1 implemented better error handling. The PS1 also received a code cleanup with functions.
DRM was disabled (added in the last pr), and more descriptive images were added to the readme.
Also, the detours were updated to the newest version in the main branch.

@Voidless7125
Copy link
Collaborator Author

The other commits are the same as the pull before, they were just on another branch.

@Voidless7125 Voidless7125 marked this pull request as draft January 19, 2025 17:08
@Voidless7125 Voidless7125 changed the title Readme update More safety updates and Readme Update Jan 19, 2025
@Voidless7125
Copy link
Collaborator Author

Voidless7125 commented Jan 19, 2025 •
edited
Loading

Finished and tested on 2.1.2.10. I haven't tested with respondus monitor because our school does not use it. (Yet...)
Most kids use the crap Chromebooks which don't support monitor, but our school is planning on switching to Windows Laptops... I use my own.

@Voidless7125 Voidless7125 marked this pull request as ready for review January 19, 2025 17:29
@Voidless7125 Voidless7125 deleted the readme-update branch January 19, 2025 17:43
@Voidless7125 Voidless7125 restored the readme-update branch January 19, 2025 17:44
@Voidless7125 Voidless7125 reopened this Jan 19, 2025
@Voidless7125
Copy link
Collaborator Author

Whoops the rename of the branch closed this :P

This was referenced Jan 19, 2025
Closed
Closed
Closed
Closed
Closed
@Voidless7125 Voidless7125 changed the title More safety updates and Readme Update More safety updates, fix for Terminal Services on Windows 10, update to Detours and Readme Update Jan 19, 2025
gucci-on-fleek
gucci-on-fleek reviewed Jan 21, 2025
View reviewed changes
Copy link
Owner

@gucci-on-fleek gucci-on-fleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes all look good to me. The documentation changes look mostly good, but I have a few comments (I'm really picky though). Thanks again for all of this!

Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
docs/404436065-10f8f221-dbee-4b02-9831-d37698b58366.png Outdated Show resolved Hide resolved
runtime_directory/sandbox_run.ps1 Show resolved Hide resolved
src/GetSystemMetrics-Hook.cpp Show resolved Hide resolved
runtime_directory/sandbox_run.ps1 Outdated Show resolved Hide resolved
@Voidless7125 Voidless7125 linked an issue Jan 21, 2025 that may be closed by this pull request
Extraction of OEM LockDown Browsers via Powershell commands is not possible #43
Closed
@Voidless7125 Voidless7125 mentioned this pull request Jan 21, 2025
Closed
@Voidless7125 Voidless7125 linked an issue Jan 21, 2025 that may be closed by this pull request
Opening Sandbox.wsb doesn't open lockdown browser, and when trying the workaround, it does not work #44
Closed
@Voidless7125 Voidless7125 added this to the 1.3 milestone Jan 22, 2025
This was unlinked from issues Jan 22, 2025
Extraction of OEM LockDown Browsers via Powershell commands is not possible #43
Closed
Opening Sandbox.wsb doesn't open lockdown browser, and when trying the workaround, it does not work #44
Closed
@Voidless7125 Voidless7125 linked an issue Jan 22, 2025 that may be closed by this pull request
Opening Sandbox.wsb doesn't open lockdown browser, and when trying the workaround, it does not work #44
Closed
gucci-on-fleek
gucci-on-fleek requested changes Jan 22, 2025
View reviewed changes
Copy link
Owner

@gucci-on-fleek gucci-on-fleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; just a couple tiny changes, but then I think that this should be good to merge. Thanks again.

Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Show resolved Hide resolved
runtime_directory/sandbox_run.ps1 Outdated Show resolved Hide resolved
docs/example-image1.png Outdated Show resolved Hide resolved
@Voidless7125
Copy link
Collaborator Author

All items resolved. Tested and ready to merge.

@Voidless7125
Copy link
Collaborator Author

@gucci-on-fleek How come some combined commits are partially verified?

@Voidless7125
Copy link
Collaborator Author

I also made some new Labels for issues and marked all issues with the applicable issue for you =)

@Voidless7125
Copy link
Collaborator Author

Voidless7125 commented Jan 22, 2025 •
edited
Loading

Don't merge yet. I just found a potential problem.
(Edit) Nvm, it's okay. I'll add a link to open the lockdown browser directly so that, in case it's not a link, you can still get to your test without adding the long PowerShell command.)

@gucci-on-fleek
Copy link
Owner

@gucci-on-fleek How come some combined commits are partially verified?

I've got “vigilant mode” enabled, so since the commit has a Co-authored-by line but hasn't been GPG signed by me, it only shows as partially verified. Not really a big deal.

I also made some new Labels for issues and marked all issues with the applicable issue for you =)

Perfect, thanks!

@gucci-on-fleek gucci-on-fleek merged commit 5804c8d into gucci-on-fleek:master Jan 23, 2025
gucci-on-fleek pushed a commit that referenced this pull request Jan 23, 2025
@Voidless7125 @gucci-on-fleek
Readme.md grammar fixes and image additions
38c6646 
(From PR #86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gucci-on-fleek gucci-on-fleek gucci-on-fleek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

Opening Sandbox.wsb doesn't open lockdown browser, and when trying the workaround, it does not work
2 participants
@Voidless7125 @gucci-on-fleek