Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major API changes #176

Merged
merged 12 commits into from
Mar 31, 2022
Merged

Major API changes #176

merged 12 commits into from
Mar 31, 2022

Conversation

gucio321
Copy link
Owner

introduce the following refactors:

  • change pkg/players/player.Player type into interface (GetMove and String)
  • introduce above change to pkg/players.Players
  • add pkg/core/pcplayer.PCPlayer type
  • add player.Player impl in pkg/core/pcplayer.PCPlayer
  • add pkg/game.humanPlayer implementation of player.Player interface
  • mov player.PlayerType into game.PlayerType
  • introduce changes above in both: giu and terminal implementations of the game

@gucio321 gucio321 self-assigned this Mar 31, 2022
@gucio321 gucio321 enabled auto-merge March 31, 2022 15:31
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #176 (d1ba275) into master (5301c39) will decrease coverage by 0.77%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   96.10%   95.32%   -0.78%     
==========================================
  Files           6        5       -1     
  Lines         359      342      -17     
==========================================
- Hits          345      326      -19     
- Misses         13       15       +2     
  Partials        1        1              
Impacted Files Coverage Δ
pkg/core/pcplayer/pc_player_engine.go 97.97% <96.66%> (-2.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5301c39...d1ba275. Read the comment docs.

@gucio321 gucio321 disabled auto-merge March 31, 2022 15:42
@gucio321 gucio321 merged commit fd7824d into master Mar 31, 2022
@gucio321 gucio321 deleted the pcplayer-refactoring branch March 31, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant