Add Pool user agent #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure the correct user agent string is sent from accounts/orders created by LiT, we compile in the referenced Pool commit.
To indicate to the server that an account/order was created by the LiT integrated Pool daemon, we overwrite the global AgentName variable.
The latest version of the Pool protos contains the new initiator field that we want to set when opening accounts or submitting orders. Because the auctioneer proto file was moved to its own package, we also have to fix a bunch of import paths.
guggero
force-pushed
the
pool-user-agent
branch
from
e6b8d24 to
a5504fc
Compare
jamaljsr
approved these changes
Jan 28, 2021
|
Thanks for the review. Going to re-open this against the upstream repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lightninglabs/pool#211 and the merge of the
pool-uibranch to master.