-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harden EscSeqUtils
#2803
Comments
Time to times I'm getting this error and the escape sequences always start with |
This mainly happens on opening a scenario because they are always running |
NetDriver in v2 has bad keyboard behavior because of this.
There is a bug somewhere that is causing
isEscSeq
to be true withcki
being null. I've added a defensive check for this as I've not been able to reliably reproduce it in a way that shows me what's causing it.I discovered something else that indicates EscSeqUtils may need to be refactored.
If the user presses a key while the terminal is sending an esc sequence (e.g. a '[35` mouse move report), that key info is lost. The result of this is no keystrokes can happen while the user is moving the mouse.
As we move to a world where all drivers rely heavily on emitting and receiving escape sequences, we need EscSeqUtils to be very robust and flexible. It works pretty darn good right now (great job!) but it is fragile and brittle. It doesn't help that the documentation for ANSI sequences and all the implementations are so sketchy.
I still haven't figured out what I screwed up in #2612 that has broken netdriver in this regard, FWIW.
Originally posted by @tig in #2745 (comment)
The text was updated successfully, but these errors were encountered: