Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Unit Tests Are failing #2923

Closed
a-usr opened this issue Oct 18, 2023 · 8 comments
Closed

Some Unit Tests Are failing #2923

a-usr opened this issue Oct 18, 2023 · 8 comments

Comments

@a-usr
Copy link

a-usr commented Oct 18, 2023

Describe the bug
UnitTests/Terminal.Gui.Drivertests/Contents_Copies_From_OS_Clipboard, UnitTests/Terminal.Gui.Drivertests/Contents_Pastes_To_OS_Clipboard and
UnitTests/Terminal.Gui.ViewTests/KeyBindings_Command fail,

To Reproduce
Steps to reproduce the behavior:

  1. Run All Unittests
  2. If using vs and Testing stops once first test fails, Filter Tests for not completed tests and execute
  3. Repeat 2 Until all tests have ran at least once
  4. See that the three mentioned Tests have failed

Expected behavior
All Unittests should complete successfully

Screenshots
image
image
image

Desktop (please complete the following information):
-Windows

Additional context
None

@tig
Copy link
Collaborator

tig commented Oct 18, 2023

We should just disable the clipboard tests. They have proven to be super unreliable and no one has been able to figure out why.

@a-usr
Copy link
Author

a-usr commented Oct 18, 2023

pwsh is actually not preinstalled on most systems. I dont have it installed, so it failed for me.

pwsh.exe is the newer version of Windows powershell (powershell.exe). powershell.exe comes preinstalled, the other one has to be downloaded from the microsoft store

https://www.reddit.com/r/PowerShell/comments/t4cuir/difference_between_windows_powershell_and/

@a-usr
Copy link
Author

a-usr commented Oct 18, 2023

Think i have found the problem.
image
the expected Value is seperated by /, meanwhile the actual value is seperated by ..
I dont have any more time today, but i will fix this if this hasn't been fixed by the time i come back to this (in a few day's time)

@a-usr
Copy link
Author

a-usr commented Oct 18, 2023

Also, to inspect the value i had to explicitly call that function from another program in case anyone is wondering

BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Oct 18, 2023
tig pushed a commit that referenced this issue Oct 20, 2023
#2924)

* Fixes #2923. Ensures only clear Instances if they really was disposed and fix unit tests.

* Add Ubuntu-20.04.

* xunit nuget package update.
@a-usr
Copy link
Author

a-usr commented Oct 23, 2023

Im closing this Issue for now, as this seems to be an issue with xUnit not being able to force the localization on some machines, and the Clipboard tests failed because i didn't do my research

@a-usr a-usr closed this as completed Oct 23, 2023
@tznind
Copy link
Collaborator

tznind commented Oct 23, 2023

Im closing this Issue for now, as this seems to be an issue with xUnit not being able to force the localization on some machines, and the Clipboard tests failed because i didn't do my research

Thanks for taking the time to report and explore this issue, it will be useful for anyone else getting similar unit test issues in future around localization.

@BDisp
Copy link
Collaborator

BDisp commented Oct 23, 2023

Do you have any link that prove that? It'll be useful too. I'm curious if some more users with a Germany machine localization are having the same issue.

@a-usr
Copy link
Author

a-usr commented Oct 23, 2023

Do you have any link that prove that? It'll be useful too. I'm curious if some more users with a Germany machine localization are having the same issue.

Not really. Im currently on a Company machine, so it also could be the company environment messing things up. I'll try it on my own machine once im home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants