Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some of the scroll features on v1 are broken. #2959

Closed
BDisp opened this issue Nov 5, 2023 · 4 comments · Fixed by #2960
Closed

Some of the scroll features on v1 are broken. #2959

BDisp opened this issue Nov 5, 2023 · 4 comments · Fixed by #2960
Labels
v1 For Issues & PRs targetting v1.x

Comments

@BDisp
Copy link
Collaborator

BDisp commented Nov 5, 2023

I'm disgusted that some of the scrolling features I've helped improve aren't working well in v1, such as:

  • Clipping scenario.
  • Editor scenario.
  • ListsAndCombos scenario.
  • Scrolling scenario.
@BDisp BDisp mentioned this issue Nov 5, 2023
Merged
8 tasks
@tig
Copy link
Collaborator

tig commented Nov 6, 2023

Were these working in v1 before?

@BDisp
Copy link
Collaborator Author

BDisp commented Nov 6, 2023

Were these working in v1 before?

The Clipping maybe not, don't remember, but the others yes.

@tig
Copy link
Collaborator

tig commented Nov 6, 2023

I don't understand how fixing things that were working before, then broke, requires so many new public APIs.

@BDisp
Copy link
Collaborator Author

BDisp commented Nov 6, 2023

I don't understand how fixing things that were working before, then broke, requires so many new public APIs.

@tig it's so only two Func. I removed the EventArgs class.

@tig tig added the v1 For Issues & PRs targetting v1.x label Nov 6, 2023
@tig tig closed this as completed in #2960 Nov 16, 2023
tig added a commit that referenced this issue Nov 16, 2023
@BDisp @tig
Fixes #2959. Some of the scroll features on v1 are broken. (#2960)
85c92f4 
* Add GrabMouseEventArgs for GrabbingMouse and UnGrabbingMouse events.

* Implementing GrabbingMouse and UnGrabbingMouse in Toplevel class.

* Fix contentBottomRightCorner to draw with the right color.

* Fix a typo.

* Fix ListView to allow scrolling.

* Add a comment to explain an extra column for the cursor at the end of line.

* Add unit tests for GrabbingMouse and UnGrabbingMouse events.

* Add unit test for a Window inside a non Toplevel.

* Removes GrabMouseEventArgs.

* Prevents throwing an exception if not subscribed.

* GrabMouse must be first called before set the dragPosition.

* Add unit test to test null on GrabbingMouse and UnGrabbingMouse.

* Fix event name.

* Prevents a toplevel to overflows his bounds to allow it can be drag.

* Fix unit test.

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v1 For Issues & PRs targetting v1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2959. Some of the scroll features on v1 are broken. BDisp/Terminal.Gui
2 participants
@tig @BDisp