Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all views are removing his subviews upon disposing on both versions. #2967

Closed
BDisp opened this issue Nov 10, 2023 · 0 comments
Closed

Not all views are removing his subviews upon disposing on both versions. #2967

BDisp opened this issue Nov 10, 2023 · 0 comments
Labels
bug

Comments

@BDisp
Copy link
Collaborator

BDisp commented Nov 10, 2023

Add System.Diagnostics.Debug.Assert (InternalSubviews.Count == 0); to the end of the protected override void Dispose (bool disposing) of the View class and will fail on some views.
BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Nov 10, 2023
@BDisp
Fixes gui-cs#2967. Not all views are removing his subviews upon dispo…
1a8b42a 
…sing on both versions.
This was referenced Nov 10, 2023
Merged
Closed
@tig tig added the bug label Nov 16, 2023
tig added a commit that referenced this issue Nov 16, 2023
@BDisp @tig
Fixes #2967. Not all views are removing his subviews upon disposing o…
8cb10f8 
…n both versions. (#2968)

Co-authored-by: Tig <tig@users.noreply.github.com>
@tig tig closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2967. V1 - Not all views are removing his subviews upon disposing BDisp/Terminal.Gui
2 participants
@tig @BDisp