You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are no dedicated unit tests for FindDeepestView right now. We need some. Write some that test the current v2_develop version that prove it works.
The current version ignores Adornments and returns a view if x/y are anywhere within view.Frame.
Simplify FindDeepestView to NOT have the out params.
Modify FindDeepestView to return Margin, Padding, or Border if x/y match. In Application.OnMouseEvent, temporarily ignore these. Eg. like this:
varview=View.FindDeepestView(Current,a.MouseEvent.X,a.MouseEvent.Y,outintscreenX,outintscreenY);// TODO: Remove this temporary filter:if(viewisAdornmentadornment){view=adornment.Parent;}
Add FindDeepestView unit tests to prove this change works.
Delete all the Adornment-specific code in Application.OnMouseEvent and add MouseEvent handling code to Adornment, Margin, Border, and Padding as appropriate (e.g. Adornment.MouseClick += Parent.SetFocus()).
Don't worry about Adornment.SubViews yet. That should happen in either THIS PR or the Close Box PR.
The text was updated successfully, but these errors were encountered:
There are no dedicated unit tests for
FindDeepestView
right now. We need some. Write some that test the currentv2_develop
version that prove it works.The current version ignores
Adornments
and returns a view if x/y are anywhere withinview.Frame
.Simplify
FindDeepestView
to NOT have theout
params.Modify
FindDeepestView
to returnMargin
,Padding
, orBorder
ifx
/y
match. InApplication.OnMouseEvent
, temporarily ignore these. Eg. like this:Add
FindDeepestView
unit tests to prove this change works.Delete all the
Adornment
-specific code inApplication.OnMouseEvent
and addMouseEvent
handling code toAdornment
,Margin
,Border
, andPadding
as appropriate (e.g.Adornment.MouseClick += Parent.SetFocus()
).Don't worry about
Adornment.SubViews
yet. That should happen in either THIS PR or theClose Box
PR.The text was updated successfully, but these errors were encountered: