Escape Key not invoking OnKeyDown on Window or Toplevel

[Bigsby]

Describe the bug
Escape key is not invoking OnKeyDown.

To Reproduce

using Terminal.Gui;

static class Program
{
    class MainWindow : Toplevel
    {
        Label labelDown;
        public MainWindow()
        {
            labelDown = new Label();
            labelDown.Text = "No key pressed yet!";
            Add(labelDown);
        }

        public override bool OnKeyDown(KeyEvent keyEvent)
        {
            labelDown.Text = $"Keydown {keyEvent}";
            return true;
        }
    }

    static void Main(string[] args)
    {
        Application.Init();
        try
        {
            Application.Run<MainWindow>();
        }
        finally
        {
            Application.Shutdown();
        }
    }
}

Expected behavior
When Escape key is pressed, OnKeyDown should be called with Key as Key.Esc.

Desktop:

• OS: macOS 14.4.1
• Terminal: Terminal and iTerm2
• Version: Terminal.Gui v1.16.0, v2.0.0-pre.214

[Bigsby]

@tig , Note that I updated the issue and added that I also tested this in version 2 and the issue remains. Maybe the tagging should be updated.

[tig]

Thanks.

This is likely due to the fact that CursesDriver think's it cute to support Esc...Key sequences to support the ancient *nix idiom.

I've never been a fan of that as it relies on arbitrary timing and is actually not needed.

We will fix this.

[dodexahedron]

This is likely due to the fact that CursesDriver think's it cute to support Esc...Key sequences to support the ancient *nix idiom.

😫

We will fix this.

🥳

[BDisp]

@tig , Note that I updated the issue and added that I also tested this in version 2 and the issue remains. Maybe the tagging should be updated.

In the version 2 it's working as expected and so nothing need to be fixed.

explorer_0n4i0k2S9M.mp4

To test copy and paste this code on a scenario.

    public override void Main ()
    {
        Application.Init ();
        try
        {
            Application.Run<MainWindow> ().Dispose ();
        }
        finally
        {
            Application.Shutdown ();
        }
    }

    class MainWindow : Toplevel
    {
        Label labelDown;
        public MainWindow ()
        {
            labelDown = new Label ();
            labelDown.Text = "No key pressed yet!";
            Add (labelDown);
        }

        public override bool OnKeyDown (Key keyEvent)
        {
            labelDown.Text = $"Keydown {keyEvent}";

            if (keyEvent == Key.Esc && MessageBox.Query ("Quit", "Do you really want to exit?", "Ok", "Cancel") == 0)
            {
                Application.RequestStop();
            }
            return true;
        }
    }

[Bigsby]

@BDisp , testing....

[Bigsby]

So. I tested against the latest versions in Nuget and every version from 2.0.0-pre.1221 onwards (inclusive) build but throw an exception exception on run. This:

Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'JetBrains.Annotations, Version=4242.42.42.42, Culture=neutral, PublicKeyToken=1010a0d8d6380325'. The system cannot find the file specified.

Anyhow, version 2.0.0-pre.949 works fine. Thank you!

[Bigsby]

I closed this for me but, maybe, you want to keep it open for v1 Maintenance. I'll do as you see fit. And I'll be happy to test it then.

[BDisp]

I closed this for me but, maybe, you want to keep it open for v1 Maintenance. I'll do as you see fit. And I'll be happy to test it then.

Open again, please. After the PR is merged it will be automatically closed. Thanks.

[Bigsby]

Tested in version 1.17.0-pre.62. All good! Great work!

[tig]

I'm working on getting v1.17.0 pushed to nuget right now...