Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2382. Nested views throws TopologicalSort exception if they reference Pos/Dim to the root view. #2383

Closed
wants to merge 3 commits into from

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Feb 26, 2023

Fixes #2382 - When the root of the nested views is valid, so not null, the exception must not throw.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig
Copy link
Collaborator

tig commented Feb 28, 2023

@BDisp would you categorize this as a "critical bug that must be fixed in v1"?

If not, can we just focus it on v2 and leave it be in v1?

@BDisp
Copy link
Collaborator Author

BDisp commented Feb 28, 2023

Yes its critical for v1 too. I already made these changes in your critical setrelativelayout-improvments branch.

@BDisp
Copy link
Collaborator Author

BDisp commented Feb 28, 2023

@tig if you merge my PR to your critical changes branch and merge it to the develop, we can close this one. I couldn't do a cherry pick because they have different versions. After that we all be focused on the V2. Do you agree?

@BDisp
Copy link
Collaborator Author

BDisp commented Mar 1, 2023

Closing this because it was included in the v2 on PR #2385.

@BDisp BDisp closed this Mar 1, 2023
@BDisp BDisp deleted the topologicalsort-fix branch March 1, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested views throws TopologicalSort exception if they reference Pos/Dim to the root view.
2 participants