Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2486 - Removes old Border and fixes a litany of related things #2525

Merged
merged 13 commits into from
Apr 10, 2023

Conversation

tig
Copy link
Collaborator

@tig tig commented Apr 10, 2023

Fixes #2468

Also:

  • Fixes Refactor TextFormatter tests #2521
  • BREAKING CHANGE: Renames BorderStyle to LineStyle and moves defn to LineCanvas
  • Refactors some of View
    • renames privates with_ etc...
    • Pulls HotKey code from Button
  • BREAKING CHANGE: Removes many parameterized constructors from Dialog, Window, FrameView etc...
  • Renames Toplevel.EnsureVisibleBounds to GetLocationThatFits to be more clear
  • Adds, Refactors, cleans up, and renames many unit tests

Notes:

  • The various Borders UI Catalog scenarios are still in a hacky condition

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig requested a review from migueldeicaza as a code owner April 10, 2023 23:09
@tig tig added the breaking-change For PRs that introduces a breaking change (behavior or API) label Apr 10, 2023
@tig tig merged commit a637f8a into gui-cs:v2_develop Apr 10, 2023
@tig tig deleted the v2_new_border_fixes_2486 branch April 3, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change For PRs that introduces a breaking change (behavior or API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant