-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2683 - Adds an ITableSource which wraps a TreeView<T> #2685
Conversation
Oh my, this looks perfect! Can't wait to put my hands on it |
(deleting TreeTableExample.cs)
Ok I've marked this as ready for review now. I've added both mouse and keyboard support for expansion/collapse. I've also put the scenario into TableEditor in UICatalog so it can be more easily tested with other TableView features (styles, checkboxes etc). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. See my minor comments.
/// </summary> | ||
/// <typeparam name="T"></typeparam> | ||
public class TreeTableSource<T> : IEnumerableTableSource<T>, IDisposable where T : class { | ||
private TreeView<T> tree; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please prefix privates with _
and don't use this.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in bc14970
Terminal.Gui/used2.txt
Outdated
@@ -0,0 +1,92 @@ | |||
nf-dev-git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a demo file? Put it in the UI Catalog/Scenarios folder? Give it a name that will help identify it's purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops was not meant to be comitted. This was a left over temp file from when I was adding the nerd fonts to file dialog. Have removed.
Think I have addressed all the points. Let me know if I missed any or misinterpreted. |
Fixes #2683 - Adds an
ITableSource
which wraps aTreeView<T>
@LPeter1997 the quick win is done, now the 90% effort polishing happens ;)
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)