Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] truecolor support #2729

Closed
wants to merge 111 commits into from

Conversation

GamerGirlandCo
Copy link

@GamerGirlandCo GamerGirlandCo commented Jun 29, 2023

Fixes #48 - Add true color support

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

veeman and others added 30 commits March 1, 2022 16:03
@BDisp
Copy link
Collaborator

BDisp commented Jun 29, 2023

Very good work, thanks. I think @tig would prefer you submit this PR based on the https://github.com/tig/Terminal.Gui/tree/v2_fixes_666_console_driver_dupes instead of the v2_develop branch, as @adstep did on the tig#15. Maybe it's a good idea you merge the @adstep's branch into your PR and adjust the better of the two PR and leverage your changes to the others drivers.
Please review the AttributeJsonConverter.cs changes because I think the new Attribute (-1) will getting invalid colors, as it need to get the pair´s foreground/background colors.

@GamerGirlandCo
Copy link
Author

Please review the AttributeJsonConverter.cs changes because I think the new Attribute (-1) will getting invalid colors, as it need to get the pair´s foreground/background colors.

done!

@tig tig marked this pull request as draft July 5, 2023 23:08
@tig
Copy link
Collaborator

tig commented Jul 5, 2023

This will be merged as part of #2612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants