Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2787. MenuItem with CanExecute returning false is select when a MenuBar is opened. #2788

Merged
merged 6 commits into from
Aug 11, 2023

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Aug 6, 2023

Fixes #2787 - The IsEnabled method weren't used to check if it can be execute first.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner August 6, 2023 18:45
@tig tig merged commit 42fcc35 into gui-cs:develop Aug 11, 2023
1 check passed
@tig
Copy link
Collaborator

tig commented Aug 11, 2023

@BDisp can you bring this fix forward into v2_develop too? Thanks.

@BDisp BDisp deleted the v1_menu-can-execute-false-fix_2787 branch August 11, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MenuItem with CanExecute returning false is select when a MenuBar is opened.
2 participants