-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2789. StatusItem should have a disabled attribute if it can't execute. #2790
Conversation
Why is this targetting v1? We agreed we will not add new capabilities to v1, but only v2. |
@tig I consider this a compatible change for v1 with no breaking change and I'll also submit a PR targeting to the v2 as well. The first release for v2 will take still a long time and we need to keep v1 pleasant as possible. I really hope you understand my observation. |
But we agreed we were not adding anything new to v1. Every bit of focus we put into v1 delays v2. I think we're pretty close to getting v2 done. We just need to focus on it! |
@tig we agree not adding new features but not nothing about improving the existing one. I'm focused on v2 but actually I felling some like blocked without know where to go for now. What I did on |
The Project has tons of things that need working on. https://github.com/orgs/gui-cs/projects/1/views/1
I do not see where a real customer has asked for this functionality. Did I miss that? |
I'm a contributor. Doesn't I haven't that right as well, for god sake. No more comments. Finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also submit a v2 PR for this. Thanks.
Rest assured. All the PR's you ask or asked to submit to v2 I will do it. Don't forget to merge this one, please :-) |
Fixes #2789 - Adding
CanExecute
property allow leveraging the power of conditional executions.Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)