-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2793. Windows Terminal still show vertical scroll bar using WindowsDriver. #2794
Fixes #2793. Windows Terminal still show vertical scroll bar using WindowsDriver. #2794
Conversation
…ing WindowsDriver.
I think this finally fixes things! Can you please address my review comment? |
I also think so.
@tig I don't see any review comment of your. Where it's? |
|
@tig but do you know why I'm not seeing the reviews that is in the image in this PR? |
Maybe I didn't submit correctly? I just tried again. |
For me the |
Thinking better, to really test if this PR does the job we want is better running on an open terminal to see the behavior after exit the app. If it's through VS2022 debugger we will not see that behavior. Run with different terminals. |
I agree. This is how I do my testing. |
@tig can you use the mouse on ConEmu? I don't know if there is some setting. |
Fixes #2793 - Since WT doesn't allows resizing the buffer using Win32 API, we need to use the
"\x1b[3J"
escape sequence. This issue only happens runningWindowsDriver
onWindows Terminal
. @tig please reconsider this because we mustn't allow WT breaking the back buffer because the scroll bar is enabled after resizing. With all others drivers this issue doesn't happens on WT.Edit:
There is no need to use
"\x1b[3J"
but only"\x1b[?1049h"
to activate alternate buffer on enter and"\x1b[?1049l"
to disable alternate buffer on exit. Only valid for theWindows Terminal
.Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)