Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2799. Adds TrueColor support to NetDriver #2802

Merged
merged 25 commits into from
Aug 12, 2023

Conversation

tig
Copy link
Collaborator

@tig tig commented Aug 11, 2023

  • Fixes Add TrueColor support to NetDriver #2799
  • Supports Windows Terminal
  • Supports conhost
  • Supports WSL
  • Improves WindowsDriver too (ensures Force16Color is true when not running in WT).
  • Adds diagnostics flag to UICatalog (need to add ConfigurationManager setting too.
  • Updates unit tests to test new flags (and makes progress on letting all consoledrivers work in unit tests)

UWWqmpG 1

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig marked this pull request as draft August 11, 2023 13:36
@tig tig marked this pull request as ready for review August 11, 2023 16:09
@tig tig merged commit ad23a10 into gui-cs:v2_develop Aug 12, 2023
@tig tig deleted the v2_fixes_2799_truecolor_netdriver branch April 3, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant