Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2836. v1 RequestStop while a ContextMenu is open can throw an exception. #2837

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Aug 28, 2023

Fixes #2836 - If another toplevel is opening in the Closing event when the app is almost to finish the OnLeave method already closed the Context.Menu and thus is null.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner August 28, 2023 23:11
@tig tig merged commit 06ef44b into gui-cs:develop Aug 30, 2023
1 check passed
@BDisp BDisp deleted the v1_request-stop-context-menu-fix_2836 branch August 30, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1 RequestStop while a ContextMenu is open can throw an exception.
2 participants