Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2847. CursesDriver doesn't processing response from task threading. #2848

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Aug 31, 2023

Fixes #2847- On the PR #2786 I ruined this one, sorry. I also fixed the button text after finished the task.
Also fixes #2860 - When the pollTimeout == -1 the poll method seem to instruct it must wait until some action is detected. Setting the pollTimeout = 0, seem to fix the issue.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@tig tig merged commit b37bdcd into gui-cs:develop Sep 29, 2023
1 check passed
@BDisp BDisp deleted the v1_cursesdriver-threading-fix_2847 branch September 29, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants