-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2928. In the v2 version, using Chinese will cause UI confusion. #2941
Conversation
This test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments.
2cbafd6
to
919df85
Compare
@BDisp you are chasing your tail here. Please see my fix to #2610. You'll note that the
Please stop trying to hack WindowsDriver to fix this; it's not worth it IMO. If people want to use conhost, they should use netdriver. Note |
I don't think so.
Yes, but where is the 'WindowsDriver', the faster one like the 'CursesDriver'?
Yes and they will freezing on Windows using
Yes you are right but to use Ansi escape sequences on Windows only with |
@tig I think the best option is submit a PR to your branch and close this one. Do you agree? |
Fixes #2928- Fixes wide and non-bmp unit points.
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)