Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2985. Application.RunState must be responsible for dispose the Toplevel property. #2986

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Nov 13, 2023

Fixes #2985 - Application.Top can be null as the Application.Current if the toplevels stack is empty. Thus avoids call Application.Shutdown method to set Application.Top to null.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig merged commit 720ba93 into gui-cs:develop Nov 16, 2023
1 check passed
@BDisp BDisp deleted the v1_runstate-disposing-fix_2985 branch November 16, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application.RunState must be responsible for dispose the Toplevel property.
2 participants