Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for publishing UICatalog as single file #3074

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

tznind
Copy link
Collaborator

@tznind tznind commented Dec 23, 2023

I was experimenting with <PublishSingleFile>true</PublishSingleFile> and UICatalog. I have discovered that it more or less works. Only barrier I had was IL3000

Solution is here just to fallback on System.AppContext.BaseDirectory.

This PR does not itself change to single file, it just strengthens the existing code so that if it were run under such build options then it would not crash.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tznind tznind requested a review from tig as a code owner December 23, 2023 18:08
@tig tig merged commit e885af0 into gui-cs:v2_develop Dec 26, 2023
BDisp pushed a commit to BDisp/Terminal.Gui that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants