Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3100 - Add constructor overload to SliderOption<T> #3101

Merged
merged 4 commits into from
Dec 31, 2023

Conversation

tznind
Copy link
Collaborator

@tznind tznind commented Dec 30, 2023

Fixes #3100- Adds new constructor to SliderOption<T> for populating values (Legend etc).

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tznind tznind requested a review from tig as a code owner December 30, 2023 02:27
@tznind tznind changed the title Add constructor overload to SliderOption Add constructor overload to SliderOption<T> Dec 31, 2023
@tznind
Copy link
Collaborator Author

tznind commented Dec 31, 2023

@tig when you get a chance can you please review this and also #3103 as this will unblock my work on Slider support in TerminalGuiDesigner

@tig tig merged commit 8954fa5 into gui-cs:v2_develop Dec 31, 2023
@tznind
Copy link
Collaborator Author

tznind commented Dec 31, 2023

Thanks <3

@tig tig changed the title Add constructor overload to SliderOption<T> Fixes #3100 - Add constructor overload to SliderOption<T> Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants