-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2944. TreeView
unit tests fail intermittently: Ensures Attribute
and Color
are read only value types
#3163
Merged
tig
merged 19 commits into
gui-cs:v2_develop
from
tig:v2_fixes_2944_attribute_colorname
Jan 13, 2024
Merged
Fixes #2944. TreeView
unit tests fail intermittently: Ensures Attribute
and Color
are read only value types
#3163
tig
merged 19 commits into
gui-cs:v2_develop
from
tig:v2_fixes_2944_attribute_colorname
Jan 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On this:
Now that both [JsonConverter (typeof (AttributeJsonConverter))]
public readonly struct Attribute : IEquatable<Attribute> {
/// <summary>
/// Default empty attribute.
/// </summary>
/// </remarks>
public static readonly Attribute Default = new (Color.White, Color.Black); |
BDisp
reviewed
Jan 13, 2024
BDisp
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Veryyyyy nice work. I love it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
TreeView
sometimes causing unit test failure #2944Todo:
Color
a readonly value type with unit test to prove itColor.ColorName
to beget
only. We're lucky in that the only code in the project that doessomeAttribute.ColorName = colorName
are in unit tests! To convince myself I'm correct on this, I commented out all those tests that setColorName
and the TreeView case no longer fails.Color.R/G/B/A/Rgba/
to beget
only.For another time:
ColorScheme
in the same way. I spent an hour yesterday on an issue where I had donevar cs = colorScheme
vsvar cs = new ColorScheme(colorScheme)
. This one is gonna be harder, as there's tons of code that will break, I fear. We'll do this in : Colors:ColorSchemes
refactor - Should honor terminal color settings etc... #2381Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)