Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2095. Resizing when a context menu is open causes the Enter event to get spammed #3193

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Fixes #2095. Resizing when a context menu is open causes the Enter event to get spammed #3193

merged 2 commits into from
Jan 20, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jan 19, 2024

Fixes

Proposed Changes/Todos

  • ContextMenu now close on terminal resizing

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner January 19, 2024 22:34
@BDisp
Copy link
Collaborator Author

BDisp commented Jan 19, 2024

@tig do you know why this warning is showing?

image

tig
tig approved these changes Jan 20, 2024
View reviewed changes
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@tig tig merged commit b65092f into gui-cs:develop Jan 20, 2024
4 checks passed
@BDisp BDisp deleted the v1_contextmenu-resize_2095 branch January 20, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tig tig tig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resizing when a context menu is open causes the Enter event to get spammed
2 participants
@BDisp @tig