Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3276. Adornment.Bounds/FrameToScreen #3277

Merged
merged 9 commits into from
Feb 28, 2024

Conversation

tig
Copy link
Collaborator

@tig tig commented Feb 28, 2024

Fixes

Proposed Changes/Todos

  • Write some that test the current v2_develop version that prove it works.
  • Simplify FindDeepestView to NOT have the out params. Modify callers to call view.FrameToScreen on the returned view instead.
  • Fix bugs mentioned here: Fixes #2489. Build scrolling into View. #3254 (comment)

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig merged commit c21107e into gui-cs:v2_develop Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant