Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3512. Ctrl+Z not suspending #3515

Merged
merged 18 commits into from
Jun 9, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented May 29, 2024

Fixes

Proposed Changes/Todos

  • Add #define UNIX_KEY_BINDINGS

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner May 29, 2024 20:18
Terminal.Gui/Views/Toplevel.cs Outdated Show resolved Hide resolved
@BDisp BDisp marked this pull request as draft May 30, 2024 14:35
@BDisp BDisp marked this pull request as ready for review May 31, 2024 22:41
Copy link
Collaborator

@dodexahedron dodexahedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than hot loops, you can just start a free-running timer at startup and an event handler when it ticks.

Should be like... half the code, if even that much.

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. See my comments.

Terminal.Gui/ConsoleDrivers/ConsoleDriver.cs Show resolved Hide resolved
@tig tig merged commit e8c8d58 into gui-cs:v2_develop Jun 9, 2024
1 check passed
@BDisp BDisp deleted the v2_3512-ctrl-z-suspend-unix-fix branch June 9, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants