Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2598. Trying to run self-contained application on Ubuntu 22 (Linux-x64), error regarding libdl.so #3562

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Fixes #2598. Trying to run self-contained application on Ubuntu 22 (Linux-x64), error regarding libdl.so #3562

merged 2 commits into from
Jun 26, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jun 24, 2024

Fixes

Proposed Changes/Todos

  • Added NET8_0

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner June 24, 2024 23:52
@BDisp BDisp mentioned this pull request Jun 24, 2024
Closed
dodexahedron
dodexahedron suggested changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@dodexahedron dodexahedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested to use the symbol made for this scenario

Terminal.Gui/ConsoleDrivers/CursesDriver/UnmanagedLibrary.cs Outdated Show resolved Hide resolved
@tig tig merged commit 902a811 into gui-cs:develop Jun 26, 2024
4 checks passed
@BDisp BDisp deleted the v1_2598_self-contained-net80-fix branch June 26, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodexahedron dodexahedron dodexahedron requested changes

@tig tig tig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trying to run self-contained application on Ubuntu 22 (Linux-x64), error regarding libdl.so
3 participants
@BDisp @tig @dodexahedron