Fixes #3499. Finishes Dim.Auto implementation

[tig]

Fixes

• Fixes Finish Dim.Auto (Content) #3499

Proposed Changes/Todos

• Todo 1

Pull Request checklist:

• I've named my PR in the form of "Fixes #issue. Terse description."
• My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
• My code follows the Terminal.Gui library design guidelines
• I ran dotnet test before commit
• I have made corresponding changes to the API documentation (using /// style comments)
• My changes generate no new warnings
• I have checked my code and corrected any poor grammar or misspellings
• I conducted basic QA to assure all features are working

[dodexahedron]

A couple of suggestions around completeness/formality and performance.

Otherwise, 👍

[tig]

@dodexahedron - This is a draft. I think it would be best if you hold off reviewing until I say it's ready for review.

[dodexahedron]

Yep I was aware. I figure if a PR has been created, may as well take a gander at it and share any thoughts that occur, in case any items impact the unfinished work. 🤷‍♂️

[dodexahedron]

I'm gonna branch from your branch real quick and shoot you over a PR to your branch for a couple of biggies that keep bugging me in TextFormatter and some of the StringExtensions stuff.

I'll do them in a conditional compile so you can compare easily before taking any replacements and to avoid conflicts.

I suppose I should specify I'll do it when the debugging and refinements here settle down a bit.

[tig]

I'm done for now. Go at it.

[dodexahedron]

Coolio.

I'll try to keep it as small and contained as I can. 😅

Gonna do some benchmarks to verify as well.

Do you have your ARM system handy? I'd love to see how some of the SIMD code behaves on that.

[BDisp]

Because the UICatalog.cs file encoded as CRLF on Windows, C#'s verbatim and raw string quotes get screwed up.

Changing the code to oldskool fixes it:

Finally you understanded that using string quotes on unit tests screw the result many times 😃

[dodexahedron]

I think we might actually have a problem related to newlines that I need to check out, that those comments and some changes I'm working on brought to mind.

I need to test it on other platforms though, so I'll do that another time.

[BDisp]

@tig I confirm that the about dialog is now working well on all drivers.
On cross platform using C++ projects that use CMake, automatically the source is copied to the WSL and run the apps or unit tests from there and thus don't have this problem. Using C# this magic isn't automatically done, I think.

[BDisp]

Here the print screen:

@tig did you can run these "113 Not Run" unit tests?

[tig]

Here the print screen:

@tig did you can run these "113 Not Run" unit tests?

Github action:

Local Windows:

Local Ubuntu/WSL:

[BDisp]

Local Ubuntu/WSL also give me 113 Not Run unit tests. I think it's related for you are using VS2022 preview version and I'm not.

I saw your Local Windows unit tests was done with ReSharper Unit Test Explorer. Does the VS2022 Test Explorer showed some Not Run tests?

[tig]

Local Ubuntu/WSL also give me 113 Not Run unit tests. I think it's related for you are using VS2022 preview version and I'm not.

Click on the blue "Not Run" filiter button. What are the 113 tests? That might provide some clue to what's going on?

I saw your Local Windows unit tests was done with ReSharper Unit Test Explorer. Does the VS2022 Test Explorer showed some Not Run tests?

My version - I'm about to upgrade to Preview 4.0 tho:

Test results using Test Explorer. Zero "Not Run" for both Windows and Ubuntu:

But clearly VS Test Explorer is tracking different things or doesn't know how to count...

Resharper counts differently. Frankly, I trust its ability to count more that VS Test Explorer.

Note dotnet test has it's own version of world events:

Github Action (Windows):

Local dotnet test (Windows):

Local dotnet test (WSL with independent clone of tig/v2_3499-Finish-DimAuto):

[BDisp]

Click on the blue "Not Run" filiter button. What are the 113 tests? That might provide some clue to what's going on?

My VS2022 version:

Never mind. It's probably anything already fixed on the preview version. Thanks for your attention.

[tig]

I updated my previous post while you were typing, BTW. May want to look at it again.

I doubt this has anything to do with VS preview. Have you tried a dotnet clean and VS restart?

[tig]

Do you have your ARM system handy? I'd love to see how some of the SIMD code behaves on that.

@dodexahedron , yep! Just let me know how to run whatever tests you're running. I really want to learn to instrument and measure C# perf better!

[tig]

@dodexahedron, am I holding this correctly now?

[BDisp]

I doubt this has anything to do with VS preview. Have you tried a dotnet clean and VS restart?

Yes. See the count of unit tests differs from Test Explorer and ReSharper Unit Test Explorer and also from your count if unit tests. Strange.

[BDisp]

Finally all tests are ran, although the count of both difere.

[dodexahedron]

@dodexahedron, am I holding this correctly now?

🤣

Yes

There are several ways to feed it data.

If you want to feed the same values to a bunch of Theories, it's a good idea to just define a static array of it so you can reuse it for them all. That's what the [CombinatorialMemberData(nameof(TheArrayYouMade))] is for.

[dodexahedron]

Do you have your ARM system handy? I'd love to see how some of the SIMD code behaves on that.

@dodexahedron , yep! Just let me know how to run whatever tests you're running. I really want to learn to instrument and measure C# perf better!

Cool.

I have a bit of code for you to run on that machine if you don't mind. Basically just checking what .net thinks it can and can't do with advanced instruction sets and whatnot on your hardware, OS, and .net combo.

But it's on a machine that is currently being.... let's say temperamental.... Dell will be out tomorrow to replace it so unless I get bored and write that up again it'll be tomorrow. 😅

What chip is it?

[tig]

Snapdragon elite

[dodexahedron]

Coolio. That gets me the hardware info. Now just to see what the runtime reports once I get you that code.

What OS(es) you got on that bad boy?

[tig]

Coolio. That gets me the hardware info. Now just to see what the runtime reports once I get you that code.

What OS(es) you got on that bad boy?

[dodexahedron]

Do you happen to also have a bare metal linux distro on there as well?

If not, I can dig up a raspberry pi I'm not currently using for some tests on the chip that's got.

[tig]

Do you happen to also have a bare metal linux distro on there as well?

If not, I can dig up a raspberry pi I'm not currently using for some tests on the chip that's got.

nope

[tig]

@dodexahedron do you think you'll have your performance patch done today?

I'd really like to get this merged. I need to know if I should wait.

[dodexahedron]

Go ahead and merge it. I'll rebase.