Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #418 and #931. Unix terminal hangs after exit. #953

Merged
merged 4 commits into from
Apr 27, 2021

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Oct 12, 2020

Also fixes #418.

@BDisp BDisp changed the title Fixes #931. Unix terminal hangs after exit. Fixes #418 and #931. Unix terminal hangs after exit. Oct 12, 2020
@BDisp BDisp marked this pull request as draft October 13, 2020 16:40
@BDisp
Copy link
Collaborator Author

BDisp commented Oct 13, 2020

Is preferable stay with this issue than merge this PR until the screen resize is fixed too.

@migueldeicaza
Copy link
Collaborator

Ok, I read the issue mentioned here, and this seems to be a disagreement between .NET Core and PowerShell and Gui.cs, because whatever code is in PowerShell is incomplete, and should be using the proper Application Mode sequences.

That said, I can understand why this would be desirable, and I think that rather than adding a custom hack (and one that should really use tigetstr ("smkx") and tigetstr ("rmkx")) that we should introduce two API entry points: Enter/Leave keyboard-application mode, and the PowerShell integration would have to explicitly enable/disable those, rather than hiding these inside the regular codepath - and also hardcoding these constatnts.

@BDisp BDisp marked this pull request as ready for review April 27, 2021 14:44
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Is this really all that's needed to fix this?

Since I could never repro the issue, I'm nervous about declaring victory. I'll merge this and then we can ask folks to verify.

@tig tig merged commit c4e744a into gui-cs:main Apr 27, 2021
@BDisp BDisp deleted the ubuntu-hangs branch April 27, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CursesDriver should emit the "Set cursor key to application mode" ANSI escape code when it exits
3 participants