Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#41 and #949. Unit test to compare the difference between System.Rune and System.Text.Rune. #975

Merged
merged 2 commits into from
Oct 28, 2020

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Oct 26, 2020

No description provided.

@tig
Copy link
Collaborator

tig commented Oct 26, 2020

This may sound sacrilegious, but why do we use nstack at all?

@BDisp
Copy link
Collaborator Author

BDisp commented Oct 26, 2020

I don't know why it gave the error.

@BDisp
Copy link
Collaborator Author

BDisp commented Oct 27, 2020

This may sound sacrilegious, but why do we use nstack at all?

Because of the ustring type that I think only exists in that library.

@tig
Copy link
Collaborator

tig commented Oct 27, 2020

This may sound sacrilegious, but why do we use nstack at all?

Because of the ustring type that I think only exists in that library.

I meant to ask, why are we even using ustring?

@BDisp
Copy link
Collaborator Author

BDisp commented Oct 27, 2020

I meant to ask, why are we even using ustring?

I do not know why. It has always existed here. In fact, it was here that I learned of the existence of this type. Only @migueldeicaza can answer that.

@tig tig merged commit b521a07 into gui-cs:master Oct 28, 2020
@BDisp BDisp deleted the rune-versions branch October 28, 2020 16:54
@BDisp
Copy link
Collaborator Author

BDisp commented Oct 30, 2020

This may sound sacrilegious, but why do we use nstack at all?

Because of the ustring type that I think only exists in that library.

I meant to ask, why are we even using ustring?

@tig I think @migueldeicaza will prefer to use NStack because System.Text.Rune is not available in net472 and in netstandard2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants