Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAI] Image inputs and JSON structured outputs #1134

Merged
merged 20 commits into from
Feb 27, 2025

Conversation

hudson-ai
Copy link
Collaborator

Punchline:

Screenshot 2025-02-26 at 12 53 07 PM

Details:

Probably not quite "release ready", but we're getting close. I may go take a nap.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 57.55102% with 104 lines in your changes missing coverage. Please review.

Project coverage is 47.24%. Comparing base (9fe8b26) to head (5512b0f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
guidance/models/_openai.py 14.75% 52 Missing ⚠️
guidance/_ast.py 75.71% 17 Missing ⚠️
guidance/models/_base/_client.py 66.66% 12 Missing ⚠️
guidance/models/_engine/_client.py 76.19% 10 Missing ⚠️
guidance/library/_gen.py 60.00% 6 Missing ⚠️
guidance/models/_base/_model.py 50.00% 5 Missing ⚠️
guidance/_grammar.py 88.88% 1 Missing ⚠️
guidance/library/_image.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1134      +/-   ##
==========================================
+ Coverage   43.44%   47.24%   +3.80%     
==========================================
  Files          72       78       +6     
  Lines        5849     5522     -327     
==========================================
+ Hits         2541     2609      +68     
+ Misses       3308     2913     -395     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nopdive nopdive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of image inputs and JSON struct outputs it fixes previous visualization bugs that we mentioned will be pushed into main. Approved, merge when ready.

@hudson-ai hudson-ai merged commit b47a5b1 into guidance-ai:main Feb 27, 2025
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants