-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenAI] Image inputs and JSON structured outputs #1134
Conversation
This reverts commit ced8a61. ASTNodes other than GrammarNodes probably should never be exposed to users, so we should never have to stringify them. Addition with GrammarNodes doesn't make sense (we instead use Functions)
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
==========================================
+ Coverage 43.44% 47.24% +3.80%
==========================================
Files 72 78 +6
Lines 5849 5522 -327
==========================================
+ Hits 2541 2609 +68
+ Misses 3308 2913 -395 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside of image inputs and JSON struct outputs it fixes previous visualization bugs that we mentioned will be pushed into main. Approved, merge when ready.
Punchline:
Details:
Probably not quite "release ready", but we're getting close. I may go take a nap.