Add Llama to model test matrix #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riedgar-ms
commented
Mar 19, 2024
| @@ -30,6 +30,9 @@ jobs: | |||
| pip install pytest | |||
| pip install -e .[test] | |||
| if [ -f requirements.txt ]; then pip install -r requirements.txt; fi | |||
| - name: Install model-specific dependencies | |||
| run: | | |||
| pip install llama-cpp-python | |||
There was a problem hiding this comment.
Is this the bit which needs special care to get CUDA enabled @Harsha-Nori ?
There was a problem hiding this comment.
Although that wouldn't be for this particular workflow file, but when #694 gets merged and updated.
There was a problem hiding this comment.
Yeah, we'll want to figure out the test hardware configuration and then set the right flags accordingly: https://github.com/abetlen/llama-cpp-python?tab=readme-ov-file#installation-configuration
E.g. with CUDA enabled, we'll want to do:
CMAKE_ARGS="-DLLAMA_CUBLAS=on" pip install llama-cpp-python
riedgar-ms
commented
Mar 19, 2024
|
Are you OK with this @Harsha-Nori ? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working to get Llama models into the test matrix.