Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Kind request to remove package from Atmosphere #1

Merged
merged 1 commit into from
May 25, 2015
Merged

Create Kind request to remove package from Atmosphere #1

merged 1 commit into from
May 25, 2015

Conversation

dandv
Copy link

@dandv dandv commented May 25, 2015

Hey Marco,

Current Meteor 3rd party packaging best practices recommend including the upstream as a submodule in the wrapper repo, then creating package.js files that refer to it. Also, the sources should be un-minified.

I went ahead and published all Bootswatch themes that way so you don't have to worry about this stuff. Here's the source repo.

Note that adding the glyphicons font is an upstream problem with Bootswatch and I've filed an issue. To not include the Glyphicons, just install https://atmospherejs.com/twbs/bootstrap-noglyph then the official Bootswatch Paper package.

If you can do the community a favor, can you please hide the old package? It will still be installable by apps and dependent packages; it will just be hidden from Atmosphere searches:

meteor admin set-unmigrated guidouil:bootswatch-paper-noglyph

Thanks,
Dan
Atmosphere curator

guidouil added a commit that referenced this pull request May 25, 2015
Create Kind request to remove package from Atmosphere
@guidouil guidouil merged commit d77d8e7 into guidouil:master May 25, 2015
@dandv
Copy link
Author

dandv commented May 25, 2015

Um... this wasn't supposed to be merged. Did you actually LOOK at the PR? #facepalm

@guidouil
Copy link
Owner

sorry it was to urly ^^ did unpublish thought :)

@dandv dandv deleted the patch-1 branch May 25, 2015 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants