fix: prevent scroll to top on modal close #1313
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BrickheadJohnny
requested changes
Jun 24, 2024
src/components/common/Modal.tsx
Outdated
| @@ -12,7 +12,7 @@ const Modal = ({ children, ...rest }: ModalProps): JSX.Element => { | |||
| const transition = useBreakpointValue<any>(transitionValues) | |||
|
|
|||
| return ( | |||
| <ChakraModal motionPreset={transition} {...rest}> | |||
| <ChakraModal motionPreset={transition} returnFocusOnClose={false} {...rest}> | |||
There was a problem hiding this comment.
Hmm, this will disable this accessibility feature for all modals, I think we shouldn't do that. ;)
So the root of the issue is that when we close the modal, the focus returns to the NavMenu. That's incorrect, the focus should just return to the menu item which opens the modal, so could you please just fix the focus management in the edit reward modals? I think you should use the Modal component's finalFocusRef to achieve this behaviour, but not sure if it works with modals inside menus, so we might need to find a workaround for that :S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.