Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve bg symlink to absolute path #18

Merged

Conversation

mrt0rtikize
Copy link

faced a problem with symlinks and wal-telegram

my files structure is like

├── wallpaper -> /home/mrt0rtikize/Pictures/wallpapers/a_girl_red_circle.jpg
└── wallpapers
   ├── a_girl_blue_sky.jpeg
   ├── a_girl_red_circle.jpg
   ├──  ...

so in my case wal-telegram doesn't work (cuz symlink has no extension) and i think it's a common case for pywal users

i think what resolving symlinks to absolute path with readlink is easiest solution:

  • if bg is symlink - we will have absolute path instead
  • if bg is path - it will not change

Copy link
Owner

@guillaumeboehm guillaumeboehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@guillaumeboehm guillaumeboehm merged commit 9fb78ae into guillaumeboehm:master May 14, 2023
@guillaumeboehm
Copy link
Owner

Thanks for the MR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants