Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Background colour overload #46

Merged
merged 3 commits into from
May 3, 2022
Merged

Conversation

guitarrapc
Copy link
Owner

@guitarrapc guitarrapc commented May 3, 2022

// white background, black qr
canvas.Render(qr, info.Width, info.Height);

// white background, black qr
canvas.Render(qr, info.Width, info.Height, SKColors.Transparent, SKColors.Black, SKColors.White);

// black background, white qr
canvas.Render(qr, info.Width, info.Height, SKColors.Transparent, SKColors.White, SKColors.Black);

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #46 (01759bd) into main (58cbec7) will increase coverage by 1.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   67.62%   69.29%   +1.66%     
==========================================
  Files           7        7              
  Lines        1390     1420      +30     
  Branches      179      180       +1     
==========================================
+ Hits          940      984      +44     
+ Misses        424      410      -14     
  Partials       26       26              
Flag Coverage Δ
unittests 69.29% <100.00%> (+1.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SkiaSharp.QrCode/QRCodeRenderer.cs 100.00% <100.00%> (ø)
src/SkiaSharp.QrCode/QrCodeExtensions.cs 100.00% <100.00%> (+36.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58cbec7...01759bd. Read the comment docs.

@guitarrapc guitarrapc merged commit bd36edd into main May 3, 2022
@guitarrapc guitarrapc deleted the feature/background branch May 3, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant