ParticleTileData: No Restrict in Storage (AMReX-Codes#3245)

## Summary

Remove the `restrict` qualifier from `GpuArray` members in
`ParticleTileData`. We see compilation problems with, among others Clang
14.0.6 and AppleClang, for this construct.

We expect that using `restrict` (`AMREX_RESTRICT`) on APIs as well as
aliased pointers in these arrays before access should be sufficient to
prevent that the compiler thinks that individual arrays alias each other
in hot loops.

## Additional background

- WarpX build regressions since 23.03, e.g.,
  - conda-forge/warpx-feedstock#63
  - conda-forge/warpx-feedstock#64
  - ECP-WarpX/WarpX#3817
- independently, about to be remove in
AMReX-Codes#2878

Src/Particle/AMReX_ParticleTile.H

@@ -22,8 +22,8 @@ struct ParticleTileData
 
     Long m_size;
     ParticleType* AMREX_RESTRICT m_aos;
-    GpuArray<ParticleReal* AMREX_RESTRICT, NArrayReal> m_rdata;
-    GpuArray<int* AMREX_RESTRICT, NArrayInt> m_idata;
+    GpuArray<ParticleReal*, NArrayReal> m_rdata;
+    GpuArray<int*, NArrayInt> m_idata;
 
     int m_num_runtime_real;
     int m_num_runtime_int;
@@ -170,8 +170,8 @@ struct ConstParticleTileData
 
     Long m_size;
     const ParticleType* AMREX_RESTRICT m_aos;
-    GpuArray<const ParticleReal* AMREX_RESTRICT, NArrayReal> m_rdata;
-    GpuArray<const int* AMREX_RESTRICT, NArrayInt > m_idata;
+    GpuArray<const ParticleReal*, NArrayReal> m_rdata;
+    GpuArray<const int*, NArrayInt> m_idata;
 
     int m_num_runtime_real;
     int m_num_runtime_int;