New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert to using match #10

Merged

gukoff merged 1 commit into gukoff:master from bmc-msft:use-match

Feb 13, 2021

bmc-msft commented Feb 12, 2021

This PR does a few things:

Moves to using match rather than is_err() and unwrap().
Returns the PyDateTime, since this is a PyResult already
Removes to_owned(), since to_string() is already owned.


          convert to using match

ae17cde

Owner

gukoff commented Feb 13, 2021

Looks great, thanks for the contribution!

gukoff merged commit 929c697 into gukoff:master

bmc-msft deleted the use-match branch

June 24, 2021 14:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet