Put filename of pug file to process into err object if we catch an error #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
during pug.compile*
demurgos
requested changes
Jul 31, 2018
| @@ -36,6 +36,7 @@ module.exports = function gulpPug(options) { | |||
| } | |||
| file.contents = new Buffer(compiled); | |||
| } catch (e) { | |||
| e.filename = opts.filename; | |||
There was a problem hiding this comment.
This should use the fileName option for PluginError instead of mutating the cause.
new PluginError('gulp-pug', e, {fileName: opts.filename})
| @@ -13,6 +13,7 @@ test('should emit errors of pug correctly', function(t) { | |||
| .pipe(task() | |||
| .on('error', function(err) { | |||
| t.ok(err); | |||
| t.equal(err.filename, __dirname + '/fixtures/pug-error.pug'); | |||
There was a problem hiding this comment.
Path concatenation is not string concatenation. This should use path.join(__dirname, "fixtures", "pug-error.pug")
|
I fixed the CI issues in #190. You should rebase your changes on top of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during pug.compile*
Fixes #188