Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not tick in onSuccess or onError #45

Closed
phated opened this issue Jan 13, 2018 · 2 comments
Closed

Should not tick in onSuccess or onError #45

phated opened this issue Jan 13, 2018 · 2 comments

Comments

@phated
Copy link
Member

phated commented Jan 13, 2018

Running into some weird race condition stuff when an error is omitted from within one of our pumpify pipeline - Ref https://github.com/cristianl/testcase-vinyl-bug from gulpjs/gulp#2086 (comment) and mafintosh/end-of-stream#17
@phated
Copy link
Member Author

phated commented Jan 13, 2018

The asyncRunner is already nextTicked so there shouldn't be a reason to tick these.

@phated
Copy link
Member Author

phated commented Jan 14, 2018

Looks like this was added to avoid swallowing thrown errors in promises but that might be wrong.

phated added a commit that referenced this issue Jan 14, 2018
@phated
Update: Add failing test for #45
ad873f2
phated added a commit that referenced this issue Jan 15, 2018
@phated
Fix: Wrap callback call in try/catch and rethrow async (fixes #45)
e54c104
@phated phated mentioned this issue Jan 15, 2018
Open
@phated phated closed this as completed in 11fffe0 Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phated