Windows path separator #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `.` pattern for jscs for windows. Handle windows path separators when calculating base path on windows.
| var parent = globParent(ourGlob); | ||
|
|
||
| if (parent === '/' && opt && opt.root) { | ||
| basePath = path.join(opt.root); |
There was a problem hiding this comment.
would this be path.normalize since you aren't joining anything?
There was a problem hiding this comment.
Yeah, .normalize would be better. I'll change that.
|
LGTM |
|
Published as 5.3.4 - thanks again @doowb! |
phated
pushed a commit
that referenced
this pull request
Feb 16, 2017
phated
pushed a commit
that referenced
this pull request
Feb 16, 2017
phated
pushed a commit
that referenced
this pull request
Feb 16, 2017
phated
pushed a commit
that referenced
this pull request
Feb 16, 2017
phated
pushed a commit
that referenced
this pull request
Feb 20, 2017
phated
pushed a commit
that referenced
this pull request
Feb 21, 2017
phated
pushed a commit
that referenced
this pull request
Feb 21, 2017
phated
pushed a commit
that referenced
this pull request
Feb 21, 2017
phated
pushed a commit
that referenced
this pull request
Feb 21, 2017
phated
pushed a commit
that referenced
this pull request
Feb 21, 2017
phated
pushed a commit
that referenced
this pull request
Feb 21, 2017
phated
pushed a commit
that referenced
this pull request
Feb 21, 2017
phated
pushed a commit
that referenced
this pull request
Feb 21, 2017
phated
pushed a commit
that referenced
this pull request
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
.pattern for jscs for windows.This fixes #68