Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Upgrade to Liftoff v5 and avoid merging flags/config/env #259

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

phated
Copy link
Member

@phated phated commented Mar 17, 2024

This upgrades to Liftoff v5 and removes a bunch of the merging between flags, config, and the environment.

I've also decided that I don't want to merge the local config and home config, so this changes to find the first available config.

Notice that Liftoff v5 ensures that the cwd is the directory where the gulpfile as specified in the config exists. Since gulp.src/gulp.dest are often used with relative paths, it is important that the cwd match the location of the gulpfile. This is what affected the majority of the test changes.

TODO:

  • Doc updates

@phated phated requested a review from sttk March 17, 2024 00:01
@phated
Copy link
Member Author

phated commented Mar 17, 2024

@sttk please review this. I've cherry-picked it into my translations prototype to ensure these changes work with the concept.

Copy link
Contributor

@sttk sttk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phated I've reviewed it, and it looks good! Great!

@phated phated merged commit ed86da7 into master Mar 17, 2024
18 checks passed
@phated phated deleted the phated/separate-argv-env branch March 17, 2024 18:47
@github-actions github-actions bot mentioned this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants