Base for gulp.src is empty if working directory has braces

[sydorivskyi]

Relative gulp version: 4

Create any directory with brackets i.e "gulp (brackets)"

• create readme.md file
• create simple gulpfile

const gulp = require('gulp');

gulp.task('default', function () {
  return gulp.src('readme.md')
    .pipe(gulp.dest('dist'));
})

• run gulp

Actual result:
In directory dest we can see readme.md inside "gulp (brackets)" directory

Expected result:
In directory dest we can see readme.md file

[heikki]

Minimal repo https://github.com/heikki/gulp-1744

[phated]

Are parentheses generally valid in filenames? Does this fall into a glob issue? I wonder if they use parens as a special character.

[stephenlacy]

Tested latest glob and glob-stream, both return the folder cwd path correctly.

https://github.com/stevelacy/glob-parens-test

[phated]

@stevelacy does it work with a space between gulp and the first paren?

[stephenlacy]

The output from glob-stream:

``
{
cwd: '/home/sl/Projects/node/glob-parens-test (parens)',
base: '/home/sl/Projects/node/',
path: '/home/sl/Projects/node/glob-parens-test (parens)/folder/gulp (brackets)/readme.md'}

[phated]

Thanks @stevelacy - I'm really confused about this then. @heikki did you confirm that it's a problem or just create the repo?

[heikki]

@phated repo task creates gulp (brackets) dir like in the issue description, I didn't debug it further

[lukaskostial]

I'm having the same issue on Windows as our Jenkins in located in C:\Program Files (x86)\jenkins and it seems that base is evaluated to C:\ so gulp.dest then creates the full path in the destination folder (Program Files (x86)\jenkins..... ).

But it seems like glob issue. Check the base of the @stevelacy test with and without brackets in the folder name:

[lukaskostial]

It seems that it is caused by isGlob and globParent implementation where isGlob evaluates such folder name as glob...

// From is-glob
module.exports = function isGlob(str) {
  return typeof str === 'string'
    && (/[*!?{}(|)[\]]/.test(str)
     || isExtglob(str));
};

// From glob-parent
module.exports = function globParent(str) {
    str += 'a'; // preserves full path in case of trailing path separator
    do {str = path.dirname(str)} while (isglob(str));
    return str;
};

// From glob-stream :
var basePath = opt.base || globParent(ourGlob) + path.sep;

[doowb]

I did a PR to glob-stream that basically changes when the basePath is calculated to only check against the passed in glob.

This passes all the current tests and writes the readme to the correct location in the example repo.

[phated]

Thanks to the debugging by @lukaskostial / @heikki / @stevelacy and great work by @doowb this has been fixed in v5.3.3 of glob-stream