Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vinyl instance property table looks pretty bad #95

Open
phated opened this issue Oct 25, 2018 · 4 comments
Open

Vinyl instance property table looks pretty bad #95

phated opened this issue Oct 25, 2018 · 4 comments

Comments

@phated
Copy link
Member

phated commented Oct 25, 2018

The way we have styling defined to have all the other tables looking good (on desktop and mobile) is causing the Instance Property table in Vinyl documentation to look really bad. It'd be nice to fix it in that one case but still keep the others the same.

@attaradev
Copy link

@phated I would be very grateful if you can throw more light on this issue

@phated
Copy link
Member Author

phated commented Jan 2, 2019

@mikeattara the spacing for this table (https://gulpjs.com/docs/en/api/vinyl#instance-properties) doesn't look good. The description column doesn't get enough space while the throw column gets too much. I don't think we can target that table specifically without causing issues with the other tables.

@APatil010
Copy link

@phated I am new to open source contribution, i tried a few ways to target the table intended, but was unsuccessful. I have a very naive solution, if that doesn't affect the ideology or views through which the documentation was created, where we can just swap those two columns, to make it much better. Any ideas on this or anything that you think of.

@phated
Copy link
Member Author

phated commented Apr 23, 2020

@APatil010 with our new website upgrades, MDX is supported in all the documentation. We've already leverage this for https://raw.githubusercontent.com/gulpjs/gulp/master/docs/support/for-enterprise.md by adding custom classes to the code that is then styled on our website.

If you want to take another stab at this, feel free!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants