Skip to content

Conversation

ghost
Copy link

@ghost ghost commented May 20, 2023

I updated to docusaurus v 2.4.1 Please check and comment if there is any fix requires. Thank you

@ghost ghost mentioned this pull request May 20, 2023
@phated
Copy link
Member

phated commented May 24, 2023

@donghwipark have you run the new changes against the website? I'm seeing a lot of differences. For example, the navbar isn't pinned to the top of the window when you scroll any more.

@ghost
Copy link
Author

ghost commented May 24, 2023

@phated I couldn't realize that defect. I will compare with current web and please let me know defects you realised. Will fix and re-commit.

@ghost
Copy link
Author

ghost commented May 29, 2023

@phated I fixed the CSS and pushed, please have a look and give me any comments if you need. Thank you

@ghost
Copy link
Author

ghost commented Jun 1, 2023

I found some changes on text size after the upgrade. Seems default css has changed will update and commit

@ghost
Copy link
Author

ghost commented Jun 7, 2023

@phated fixed some css after comparing between the new version and current version.

@phated
Copy link
Member

phated commented Jun 15, 2023

@donghwipark that's awesome! Thanks for inspecting. Will you also please update the other dependencies that have newer versions? I noticed that docusaurus-plugin-sass and other packages are very outdated.

Also, please regenerate and commit the package-lock.json using npm i -S

@ghost
Copy link
Author

ghost commented Jun 15, 2023

@phated Sure Thank you for the guide!

@phated
Copy link
Member

phated commented Apr 28, 2024

Replaced by #149

@phated phated closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant