-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tsx support #96
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @evenstensberg 🤗
Adding this into the middle of the array messes up the test harness. If this should (purposefully) be loaded before babel is attempted, can you please adjust the tests appropriately? This also needs tests 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phated PTAL. The tests are passing for me (node v22.3.0)
@@ -498,6 +499,7 @@ var extensions = { | |||
); | |||
}, | |||
}, | |||
'tsx/dist/cjs/index.cjs', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also add it to:
.tsx
.cts
.mjs
- tsx will compile it down to CommonJS; minor caveat is that it won't handle TLA but this caveat exists with any ESM -> CommonJS compiler.
#95