Scaffold: Switch to eslint-config-gulp rules

.eslintrc

@@ -1,20 +1,8 @@
 {
-    "env": {
-        "commonjs": true,
-        "es6": true,
-        "node": true,
-        "mocha": true
-    },
-    "extends": "eslint:recommended",
-    "globals": {
-        "Atomics": "readonly",
-        "SharedArrayBuffer": "readonly"
-    },
-    "parserOptions": {
-        "ecmaVersion": 2018
-    },
-    "rules": {
-        "no-empty": ["error", { "allowEmptyCatch": true }],
-        "comma-dangle": ["error", "only-multiline"]
-    }
+  "extends": "gulp",
+  "rules": {
+    "max-len": [0, 90],
+    "max-statements": [1, 50],
+    "no-empty": ["error", { "allowEmptyCatch": true }]
+  }
 }

index.js

@@ -1,42 +1,42 @@
-const fs = require('fs');
-const util = require('util');
-const path = require('path');
-const EE = require('events').EventEmitter;
-
-const extend = require('extend');
-const resolve = require('resolve');
-const flaggedRespawn = require('flagged-respawn');
-const isPlainObject = require('is-plain-object');
-const mapValues = require('object.map');
-const fined = require('fined');
-
-const findCwd = require('./lib/find_cwd');
-const findConfig = require('./lib/find_config');
-const fileSearch = require('./lib/file_search');
-const parseOptions = require('./lib/parse_options');
-const silentRequire = require('./lib/silent_require');
-const buildConfigName = require('./lib/build_config_name');
-const registerLoader = require('./lib/register_loader');
-const getNodeFlags = require('./lib/get_node_flags');
-
-
-function Liftoff (opts) {
+var fs = require('fs');
+var util = require('util');
+var path = require('path');
+var EE = require('events').EventEmitter;
+
+var extend = require('extend');
+var resolve = require('resolve');
+var flaggedRespawn = require('flagged-respawn');
+var isPlainObject = require('is-plain-object');
+var mapValues = require('object.map');
+var fined = require('fined');
+
+var findCwd = require('./lib/find_cwd');
+var findConfig = require('./lib/find_config');
+var fileSearch = require('./lib/file_search');
+var parseOptions = require('./lib/parse_options');
+var silentRequire = require('./lib/silent_require');
+var buildConfigName = require('./lib/build_config_name');
+var registerLoader = require('./lib/register_loader');
+var getNodeFlags = require('./lib/get_node_flags');
+
+
+function Liftoff(opts) {
   EE.call(this);
   extend(this, parseOptions(opts));
 }
 util.inherits(Liftoff, EE);
 
-Liftoff.prototype.requireLocal = function (module, basedir) {
+Liftoff.prototype.requireLocal = function(module, basedir) {
   try {
-    var result = require(resolve.sync(module, {basedir: basedir}));
+    var result = require(resolve.sync(module, { basedir: basedir }));
     this.emit('require', module, result);
     return result;
   } catch (e) {
     this.emit('requireFail', module, e);
   }
 };
 
-Liftoff.prototype.buildEnvironment = function (opts) {
+Liftoff.prototype.buildEnvironment = function(opts) {
   opts = opts || {};
 
   // get modules we want to preload
@@ -64,14 +64,14 @@ Liftoff.prototype.buildEnvironment = function (opts) {
   // calculate the regex to use for finding the config file
   var configNameSearch = buildConfigName({
     configName: this.configName,
-    extensions: Object.keys(this.extensions)
+    extensions: Object.keys(this.extensions),
   });
 
   // calculate configPath
   var configPath = findConfig({
     configNameSearch: configNameSearch,
     searchPaths: searchPaths,
-    configPath: opts.configPath
+    configPath: opts.configPath,
   });
 
   // if we have a config path, save the directory it resides in.
@@ -90,11 +90,12 @@ Liftoff.prototype.buildEnvironment = function (opts) {
 
   // TODO: break this out into lib/
   // locate local module and package next to config or explicitly provided cwd
+  /* eslint one-var: 0 */
   var modulePath, modulePackage;
   try {
-    var delim = path.delimiter,
-        paths = (process.env.NODE_PATH ? process.env.NODE_PATH.split(delim) : []);
-    modulePath = resolve.sync(this.moduleName, {basedir: configBase || cwd, paths: paths});
+    var delim = path.delimiter;
+    var paths = (process.env.NODE_PATH ? process.env.NODE_PATH.split(delim) : []);
+    modulePath = resolve.sync(this.moduleName, { basedir: configBase || cwd, paths: paths });
     modulePackage = silentRequire(fileSearch('package.json', [modulePath]));
   } catch (e) {}
 
@@ -118,9 +119,9 @@ Liftoff.prototype.buildEnvironment = function (opts) {
   // load any modules which were requested to be required
   if (preload.length) {
     // unique results first
-    preload.filter(function (value, index, self) {
+    preload.filter(function(value, index, self) {
       return self.indexOf(value) === index;
-    }).forEach(function (dep) {
+    }).forEach(function(dep) {
       this.requireLocal(dep, findCwd(opts));
     }, this);
   }
@@ -152,27 +153,27 @@ Liftoff.prototype.buildEnvironment = function (opts) {
     configBase: configBase,
     modulePath: modulePath,
     modulePackage: modulePackage || {},
-    configFiles: configFiles
+    configFiles: configFiles,
   };
 };
 
-Liftoff.prototype.handleFlags = function (cb) {
+Liftoff.prototype.handleFlags = function(cb) {
   if (typeof this.v8flags === 'function') {
-    this.v8flags(function (err, flags) {
+    this.v8flags(function(err, flags) {
       if (err) {
         cb(err);
       } else {
         cb(null, flags);
       }
     });
   } else {
-    process.nextTick(function () {
+    process.nextTick(function() {
       cb(null, this.v8flags);
     }.bind(this));
   }
 };
 
-Liftoff.prototype.launch = function (opts, fn) {
+Liftoff.prototype.launch = function(opts, fn) {
   if (typeof fn !== 'function') {
     throw new Error('You must provide a callback function.');
   }
@@ -183,7 +184,7 @@ Liftoff.prototype.launch = function (opts, fn) {
     return this.completions(completion);
   }
 
-  this.handleFlags(function (err, flags) {
+  this.handleFlags(function(err, flags) {
     if (err) {
       throw err;
     }

lib/build_config_name.js

@@ -1,4 +1,4 @@
-module.exports = function (opts) {
+module.exports = function(opts) {
   opts = opts || {};
   var configName = opts.configName;
   var extensions = opts.extensions;
@@ -11,7 +11,7 @@ module.exports = function (opts) {
   if (!Array.isArray(extensions)) {
     throw new Error('Please provide an array of valid extensions.');
   }
-  return extensions.map(function (ext) {
+  return extensions.map(function(ext) {
     return configName + ext;
   });
 };

lib/file_search.js

@@ -1,13 +1,13 @@
-const findup = require('findup-sync');
+var findup = require('findup-sync');
 
-module.exports = function (search, paths) {
+module.exports = function(search, paths) {
   var path;
   var len = paths.length;
   for (var i = 0; i < len; i++) {
     if (path) {
       break;
     } else {
-      path = findup(search, {cwd: paths[i], nocase: true});
+      path = findup(search, { cwd: paths[i], nocase: true });
     }
   }
   return path;

lib/find_config.js

@@ -1,8 +1,8 @@
-const fs = require('fs');
-const path = require('path');
-const fileSearch = require('./file_search');
+var fs = require('fs');
+var path = require('path');
+var fileSearch = require('./file_search');
 
-module.exports = function (opts) {
+module.exports = function(opts) {
   opts = opts || {};
   var configNameSearch = opts.configNameSearch;
   var configPath = opts.configPath;

lib/find_cwd.js

@@ -1,6 +1,6 @@
-const path = require('path');
+var path = require('path');
 
-module.exports = function (opts) {
+module.exports = function(opts) {
   if (!opts) {
     opts = {};
   }

lib/parse_options.js

@@ -1,12 +1,12 @@
-const extend = require('extend');
+var extend = require('extend');
 
-module.exports = function (opts) {
+module.exports = function(opts) {
   var defaults = {
     extensions: {
       '.js': null,
-      '.json': null
+      '.json': null,
     },
-    searchPaths: []
+    searchPaths: [],
   };
   if (!opts) {
     opts = {};

lib/register_loader.js

@@ -1,4 +1,4 @@
-const rechoir = require('rechoir');
+var rechoir = require('rechoir');
 
 module.exports = function(eventEmitter, extensions, configPath, cwd) {
   extensions = extensions || {};

lib/silent_require.js

@@ -1,4 +1,4 @@
-module.exports = function (path) {
+module.exports = function(path) {
   try {
     return require(path);
   } catch (e) {}

package.json

@@ -34,6 +34,7 @@
     "chai": "^3.5.0",
     "coffeescript": "^1.10.0",
     "eslint": "^2.13.1",
+    "eslint-config-gulp": "^3.0.1",
     "mocha": "^3.5.3",
     "nyc": "^13.3.0",
     "sinon": "~1.17.4"

test/.eslintrc

@@ -0,0 +1,3 @@
+{
+  "extends": "gulp/test"
+}

test/fixtures/configfiles/require-md.js

@@ -1,6 +1,6 @@
 (function() {
 
-const path = require('path');
+var path = require('path');
 
 require.extensions['.md'] = function(module, filepath) {
   module.loaded = true;

test/fixtures/configfiles/require-txt.js

@@ -1,6 +1,6 @@
 (function() {
 
-const path = require('path');
+var path = require('path');
 
 require.extensions['.txt'] = function(module, filepath) {
   module.loaded = true;

test/fixtures/developing_yourself/app1/index.js

@@ -1,6 +1,6 @@
-const Liftoff = require('../../../..');
+var Liftoff = require('../../../..');
 
-const app1 = new Liftoff({
+var app1 = new Liftoff({
   name: 'app1'
 });
 

test/fixtures/developing_yourself/app2/index.js

@@ -1,6 +1,6 @@
-const Liftoff = require('../../../..');
+var Liftoff = require('../../../..');
 
-const app2 = new Liftoff({
+var app2 = new Liftoff({
   name: 'app2'
 });
 

test/fixtures/developing_yourself/main.js

@@ -1,6 +1,6 @@
-const Liftoff = require('../../..');
+var Liftoff = require('../../..');
 
-const app0 = new Liftoff({
+var app0 = new Liftoff({
   name: 'app0'
 });
 

test/fixtures/nodeflags_only.js

@@ -1,6 +1,6 @@
-const Liftoff = require('../..');
+var Liftoff = require('../..');
 
-const Test = new Liftoff({
+var Test = new Liftoff({
   name: 'test',
 });
 

test/fixtures/register_loader/require-cfg.js

@@ -1,6 +1,6 @@
 (function() {
 
-const path = require('path');
+var path = require('path');
 
 require.extensions['.cfg'] = function(module, filepath) {
   module.loaded = true;

test/fixtures/register_loader/require-conf.js

@@ -1,6 +1,6 @@
 (function() {
 
-const path = require('path');
+var path = require('path');
 
 require.extensions['.conf'] = function(module, filepath) {
   module.loaded = true;

test/fixtures/register_loader/require-rc.js

@@ -1,6 +1,6 @@
 (function() {
 
-const path = require('path');
+var path = require('path');
 
 require.extensions['.rc'] = function(module, filepath) {
   module.loaded = true;

test/fixtures/v8flags.js

@@ -1,13 +1,13 @@
-const Liftoff = require('../..');
+var Liftoff = require('../..');
 
-const Test = new Liftoff({
+var Test = new Liftoff({
   name: 'test',
   v8flags: ['--lazy']
 });
-Test.on('respawn', function (flags, proc) {
+Test.on('respawn', function(flags, proc) {
   console.log('saw respawn');
 });
 
-Test.launch({}, function (env) {
+Test.launch({}, function(env) {
   console.error(process.execArgv.join(''));
 });

test/fixtures/v8flags_config.js

@@ -1,6 +1,6 @@
-const Liftoff = require('../..');
+var Liftoff = require('../..');
 
-const Test = new Liftoff({
+var Test = new Liftoff({
   name: 'test',
   v8flags: ['--harmony'],
 });