Skip to content

Commit

Permalink
Update: Use lodash.defaultto instead of our custom method
Browse files Browse the repository at this point in the history
  • Loading branch information
phated committed Nov 28, 2017
1 parent 8554be0 commit 12a80cb
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 47 deletions.
8 changes: 0 additions & 8 deletions lib/default-value.js

This file was deleted.

12 changes: 6 additions & 6 deletions lib/prepare-write.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
var assign = require('object-assign');
var path = require('path');
var fs = require('graceful-fs');
var fo = require('./file-operations');

var valueOrFunction = require('value-or-function');
var defaultValue = require('./default-value');
var defaultTo = require('lodash.defaultto');

var fo = require('./file-operations');

var boolean = valueOrFunction.boolean;
var number = valueOrFunction.number;
Expand All @@ -19,10 +19,10 @@ function prepareWrite(outFolder, file, opt, callback) {

var defaultMode = file.stat ? file.stat.mode : null;
var options = assign({}, opt, {
cwd: defaultValue(process.cwd(), string(opt.cwd, file)),
mode: defaultValue(defaultMode, number(opt.mode, file)),
cwd: defaultTo(string(opt.cwd, file), process.cwd()),
mode: defaultTo(number(opt.mode, file), defaultMode),
dirMode: number(opt.dirMode, file),
overwrite: defaultValue(true, boolean(opt.overwrite, file)),
overwrite: defaultTo(boolean(opt.overwrite, file), true),
});
options.flag = (options.overwrite ? 'w' : 'wx');

Expand Down
14 changes: 7 additions & 7 deletions lib/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ var merge = require('merge-stream');
var sourcemaps = require('gulp-sourcemaps');
var isValidGlob = require('is-valid-glob');
var valueOrFunction = require('value-or-function');
var defaultTo = require('lodash.defaultto');

var defaultValue = require('../default-value');
var filterSince = require('../filter-since');
var getContents = require('./get-contents');
var wrapWithVinylFile = require('./wrap-with-vinyl-file');
Expand All @@ -23,13 +23,13 @@ function src(glob, opt) {
}

var options = assign({}, opt, {
buffer: defaultValue(true, boolean(opt.buffer)),
read: defaultValue(true, boolean(opt.read)),
buffer: defaultTo(boolean(opt.buffer), true),
read: defaultTo(boolean(opt.read), true),
since: date(opt.since),
stripBOM: defaultValue(true, boolean(opt.stripBOM)),
sourcemaps: defaultValue(false, boolean(opt.sourcemaps)),
passthrough: defaultValue(false, boolean(opt.passthrough)),
followSymlinks: defaultValue(true, boolean(opt.followSymlinks)),
stripBOM: defaultTo(boolean(opt.stripBOM), true),
sourcemaps: defaultTo(boolean(opt.sourcemaps), false),
passthrough: defaultTo(boolean(opt.passthrough), false),
followSymlinks: defaultTo(boolean(opt.followSymlinks), true),
});

// Don't pass `read` option on to through2
Expand Down
4 changes: 2 additions & 2 deletions lib/symlink/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ var path = require('path');
var fs = require('graceful-fs');
var through2 = require('through2');
var valueOrFunction = require('value-or-function');
var defaultTo = require('lodash.defaultto');

var sink = require('../sink');
var prepareWrite = require('../prepare-write');
var defaultValue = require('../default-value');

var boolean = valueOrFunction.boolean;

Expand All @@ -20,7 +20,7 @@ function symlink(outFolder, opt) {
function linkFile(file, enc, callback) {
var srcPath = file.path;
var symType = (file.isDirectory() ? 'dir' : 'file');
var isRelative = defaultValue(false, boolean(opt.relative, file));
var isRelative = defaultTo(boolean(opt.relative, file), false);

prepareWrite(outFolder, file, opt, onPrepare);

Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"gulp-sourcemaps": "^1.5.2",
"is-valid-glob": "^0.3.0",
"lazystream": "^1.0.0",
"lodash.defaultto": "^4.14.0",
"merge-stream": "^1.0.0",
"object-assign": "^4.0.0",
"strip-bom": "^2.0.0",
Expand Down
24 changes: 0 additions & 24 deletions test/default-value.js

This file was deleted.

0 comments on commit 12a80cb

Please sign in to comment.